[python][client] Add Decimal support to mapNumberTo functionality#23916
Open
Mattias-Sehlstedt wants to merge 1 commit into
Open
[python][client] Add Decimal support to mapNumberTo functionality#23916Mattias-Sehlstedt wants to merge 1 commit into
Mattias-Sehlstedt wants to merge 1 commit into
Conversation
442b05b to
39a2afe
Compare
6 tasks
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
39a2afe to
93a44d4
Compare
Member
|
please resolve the merge conflicts when you've time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add so that the
Pythongenerator support so that the number type can be mapped toDecimal. Note that the is strictly for the Python generator, and not for thepython-pydantic-v1generator. This is intentional since they are based upon different AbstractCodegens that do not share their logic. If it is of interest to have all Python generators share this new behavior I would suggest creating a shared type resolver so that all Python generators could get the same functionality without code duplication.The
mapNumberTofunction is retained as a scoped (argument-limited) function rather than a completely open one. This since the Python validation logic required outside knowledge that is currently not injectable by the client, so having an open function might currently be counterintuitive.Fixes: #23887
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)cc @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @arun-nalla (2019/11)
Summary by cubic
Adds support for mapping OpenAPI number types to
Decimalin thepythonclient viamapNumberTo, enabling high‑precision values (e.g., money) while preserving validation. Fixes #23887.New Features
mapNumberTonow acceptsDecimal(supported:Union[StrictFloat, StrictInt],StrictFloat,float,Decimal) and keeps numeric constraints.DecimalandStrictFloat; tests verify all mappings with a data provider.pythongenerator only; notpython-pydantic-v1.Migration
mapNumberTo: "Decimal"in the generator config (Python generator only).Written for commit 93a44d4. Summary will update on new commits.